Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v8.0.0-9768844f [release-8.0] #7984

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Mar 26, 2024

What problem does this PR solve?

Issue Number: Close #7989 , ref #4257

Update TiDB Dashboard to v8.0.0-9768844f.

This PR fixes the error that hosts/disks/statistics page can't show normally when use pd micro-service mode.

TiDB Dashboard side PR: pingcap/tidb-dashboard#1664

image

Release note

None

Test

$ make pd-server
$ cp bin/pd-server ~/.tiup/components/pd/v8.0.0-alpha-nightly/pd-server
# pd ms mode
$ tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 1 --pd.tso 1 --pd.rm 0 --kv 3 --tiflash 0 --db 1
# pd non-ms mode
$ tiup playground nightly --tiflash 0

image

Signed-off-by: baurine <2008.hbl@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx March 26, 2024 11:27
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 26, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #7984 (34b979b) into release-8.0 (92a303c) will increase coverage by 0.03%.
Report is 1 commits behind head on release-8.0.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.0    #7984      +/-   ##
===============================================
+ Coverage        73.50%   73.53%   +0.03%     
===============================================
  Files              436      436              
  Lines            48351    48351              
===============================================
+ Hits             35539    35554      +15     
+ Misses            9751     9739      -12     
+ Partials          3061     3058       -3     
Flag Coverage Δ
unittests 73.53% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2024
@baurine
Copy link
Contributor Author

baurine commented Mar 27, 2024

replaced by #7990

@baurine baurine closed this Mar 27, 2024
@baurine baurine deleted the update-tidb-dashboard/release-8.0-v8.0.0-9768844f-1711452404 branch March 27, 2024 06:40
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants