Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

fix the Reader.Read bug in parquet-go #416

Closed
glorv opened this issue Oct 9, 2020 · 0 comments · Fixed by #418
Closed

fix the Reader.Read bug in parquet-go #416

glorv opened this issue Oct 9, 2020 · 0 comments · Fixed by #418
Labels
type/bug This issue is a bug report

Comments

@glorv
Copy link
Contributor

glorv commented Oct 9, 2020

pingcap/br#548 will fix the wrong implement of Reader.Read for s3 storage Reader, but there is a bug in parquet-go that may cause reading parquet file failed. So we should update br and parquet-go together after these two pr are merged.
@glorv glorv added the type/bug This issue is a bug report label Oct 9, 2020
glorv added a commit that referenced this issue Oct 10, 2020
@glorv
update br and parquet-go to fix #416
0b76b58
@glorv glorv mentioned this issue Oct 10, 2020
Merged
kennytm pushed a commit that referenced this issue Oct 12, 2020
@glorv
local: fix infinity loop in retry get region (#418)
aa029d8 
* fix infinity loop in retry get region

* update br and parquet-go to fix #416

* update failpoint

* update mock ExternalStorage
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug This issue is a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

local: fix infinity loop in retry get region pingcap/tidb-lightning
1 participant
@glorv