Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

local: fix infinity loop in retry get region #418

Merged
merged 4 commits into from
Oct 12, 2020
Merged

local: fix infinity loop in retry get region #418

merged 4 commits into from
Oct 12, 2020

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Oct 10, 2020 •
edited
Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Related changes

Release Note

  • fix a bug that cause local backend retry get region in infinity loop

kennytm
kennytm reviewed Oct 10, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Oct 10, 2020
@glorv
Copy link
Contributor Author

glorv commented Oct 10, 2020

/run-all-tests

@YuJuncen
Copy link
Contributor

LGTM

@YuJuncen YuJuncen added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Oct 10, 2020
overvenus
overvenus approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release notes in the PR description.

@kennytm kennytm merged commit aa029d8 into master Oct 12, 2020
@kennytm kennytm deleted the fix-get-region branch October 12, 2020 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@overvenus overvenus overvenus approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix the Reader.Read bug in parquet-go
4 participants
@glorv @YuJuncen @kennytm @overvenus