Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress would direct to the wrong PD instance #2650

Closed
Yisaer opened this issue Jun 8, 2020 · 6 comments · Fixed by #2713
Closed

Ingress would direct to the wrong PD instance #2650

Yisaer opened this issue Jun 8, 2020 · 6 comments · Fixed by #2713
Assignees
@Yisaer
Labels
priority:P1 status/help-wanted Extra attention is needed type/bug Something isn't working
Milestone
v1.1.1

Comments

@Yisaer
Copy link
Contributor

Yisaer commented Jun 8, 2020

Bug Report

In our document, we recommended to use Ingress to access dashboard.

However, if there are multiple pd instances, the ingress may port the upstream to the wrong pd instance as dashboard would only be started in one pd instance.

One possible solution is to use discovery service to proxy the dashboard service. And the Ingress would expose the HTTP service for discovery service.

We can know the dashboard endpoint by visting pdapi GetConfig
@Yisaer Yisaer added the enhancement New feature or request label Jun 8, 2020
@Yisaer Yisaer changed the title Ingress would directly to the wrong PD instance Ingress would direct to the wrong PD instance Jun 8, 2020
@zjj2wry
Copy link
Contributor

zjj2wry commented Jun 8, 2020

/cc

@Yisaer Yisaer added type/bug Something isn't working and removed enhancement New feature or request labels Jun 8, 2020
@DanielZhangQD
Copy link
Contributor

tikv/pd#2508 Dashboard has supported an internal proxy to forward the request, maybe we can just enable it by default with operator deployment. @Yisaer @zjj2wry

@zjj2wry
Copy link
Contributor

zjj2wry commented Jun 8, 2020

got it, thanks. should we support this feature after pd 4.0.1 release?

@DanielZhangQD
Copy link
Contributor

got it, thanks. should we support this feature after pd 4.0.1 release?

We can finish the dev now and make it clear in the doc that it's supported from v4.0.1.

@Yisaer Yisaer mentioned this issue Jun 8, 2020
Closed
@cofyc cofyc added the status/help-wanted Extra attention is needed label Jun 10, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented Jun 10, 2020

After 4.0.1 released, I think we could update the PD Config and make Dashboard.InternalProxy enabled by a switch.

@DanielZhangQD
Copy link
Contributor

DanielZhangQD commented Jun 15, 2020 •
edited
Loading

v4.0.1 is released on 06/12.

@DanielZhangQD DanielZhangQD added this to the v1.1.1 milestone Jun 15, 2020
@Yisaer Yisaer mentioned this issue Jun 15, 2020
Merged
@zjj2wry zjj2wry assigned Yisaer and unassigned zjj2wry Jun 15, 2020
@ti-srebot ti-srebot mentioned this issue Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yisaer Yisaer

Labels
priority:P1 status/help-wanted Extra attention is needed type/bug Something isn't working
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging a pull request may close this issue.

Add switch to control the Dashboard Proxy Yisaer/tidb-operator
4 participants
@cofyc @Yisaer @zjj2wry @DanielZhangQD