Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to control the Dashboard Proxy #2713

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jun 15, 2020

What problem does this PR solve?

Close #2650

Add enableDashboardInternalProxy to control whether enable internal-proxy for pd dashboard. This would let user directly visit dashboard by discovery-service:10262.

After this pr finished, we need to update the document about access dashboard.

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Add `EnableDashboardInternalProxy` in `PDSpec` to let user directly visit PD Dashboard.

Copy link
Contributor

@zjj2wry zjj2wry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor Author

Yisaer commented Jun 15, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 2709

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4325eed into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jun 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2719

ti-srebot added a commit that referenced this pull request Jun 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress would direct to the wrong PD instance
4 participants