Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1.0.0-beta.3 #557

Merged
merged 8 commits into from
Jun 6, 2019
Merged

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jun 5, 2019

What problem does this PR solve?

  • Release TiDB Operator v1.0.0-beta.3
  • adjust stability parameters

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has documents change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

@weekface
Copy link
Contributor Author

weekface commented Jun 6, 2019

/run-e2e-tests

@weekface weekface marked this pull request as ready for review June 6, 2019 04:07
@weekface weekface requested review from tennix, xiaojingchen and aylei June 6, 2019 04:10
aylei
aylei previously approved these changes Jun 6, 2019
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1921,7 +1921,7 @@ func (oa *operatorActions) CheckScheduledBackup(info *TidbClusterConfig) error {

succededJobCount := 0
for _, j := range backupJobs {
if j.Status.Failed > 0 {
if j.Status.Failed > 3 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the pod may fail one or two times.

@@ -96,7 +96,7 @@ func NewOperatorActions(cli versioned.Interface,
const (
DefaultPollTimeout time.Duration = 10 * time.Minute
DefaultPollInterval time.Duration = 1 * time.Minute
BackupAndRestorePollTimeOut time.Duration = 30 * time.Minute
BackupAndRestorePollTimeOut time.Duration = 60 * time.Minute
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a longer restore period.

xiaojingchen
xiaojingchen previously approved these changes Jun 6, 2019
@xiaojingchen
Copy link
Contributor

/run-e2e-test

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@xiaojingchen
Copy link
Contributor

/run-e2e-test

Co-Authored-By: Tennix <tennix@users.noreply.github.com>
@weekface weekface dismissed stale reviews from xiaojingchen and aylei via 575991d June 6, 2019 05:53
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit dcfb125 into pingcap:master Jun 6, 2019
@weekface weekface deleted the release-v1.0.0-beta.3 branch June 6, 2019 07:20
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* add aliases in configure-a-tidb-cluster.md

* fix wrong aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants