-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1.0.0-beta.3 #557
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e07f8de
release v1.0.0-beta.3
weekface f9b0851
adjust stability parameters
weekface 86b3986
Merge branch 'master' into release-v1.0.0-beta.3
weekface 396e006
adjust ROADMAP.md
weekface f37f094
Merge branch 'release-v1.0.0-beta.3' of https://github.com/weekface/t…
weekface 5c92d01
Merge branch 'master' into release-v1.0.0-beta.3
xiaojingchen 575991d
Update CHANGELOG.md
weekface f8f817e
Update CHANGELOG.md
weekface File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,7 +96,7 @@ func NewOperatorActions(cli versioned.Interface, | |
const ( | ||
DefaultPollTimeout time.Duration = 10 * time.Minute | ||
DefaultPollInterval time.Duration = 1 * time.Minute | ||
BackupAndRestorePollTimeOut time.Duration = 30 * time.Minute | ||
BackupAndRestorePollTimeOut time.Duration = 60 * time.Minute | ||
getBackupDirPodName = "get-backup-dir" | ||
grafanaUsername = "admin" | ||
grafanaPassword = "admin" | ||
|
@@ -1921,7 +1921,7 @@ func (oa *operatorActions) CheckScheduledBackup(info *TidbClusterConfig) error { | |
|
||
succededJobCount := 0 | ||
for _, j := range backupJobs { | ||
if j.Status.Failed > 0 { | ||
if j.Status.Failed > 3 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these changes intended? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the pod may fail one or two times. |
||
return false, fmt.Errorf("cluster [%s/%s] scheduled backup job failed, job: [%s] failed count is: %d", | ||
info.Namespace, info.ClusterName, j.Name, j.Status.Failed) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a longer restore period.