Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1.0.0-beta.3 #557

Merged
merged 8 commits into from
Jun 6, 2019
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
300 changes: 189 additions & 111 deletions CHANGELOG.md

Large diffs are not rendered by default.

9 changes: 4 additions & 5 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,12 @@ This document defines the roadmap for TiDB Operator development.
- [x] TiDB 3.0-beta support

## v1.0.0-beta.3
- [ ] GCP one-command deployment
- [ ] Schedule TiDB pod on previous node
- [ ] Rolling update when ConfigMap changes
- [ ] Allow pausing during TiDB upgrade
- [x] GCP one-command deployment
- [x] Schedule TiDB pod on previous node
- [x] Rolling update when ConfigMap changes
- [x] Allow pausing during TiDB upgrade

## v1.0.0-beta.4
- [ ] Kustomize support
- [ ] HA deployment document
- [ ] Monitor deployment document
- [ ] Detailed Backup/Restore document
Expand Down
2 changes: 1 addition & 1 deletion charts/tidb-cluster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ services:
type: ClusterIP

discovery:
image: pingcap/tidb-operator:v1.0.0-beta.2
image: pingcap/tidb-operator:v1.0.0-beta.3
imagePullPolicy: IfNotPresent
resources:
limits:
Expand Down
2 changes: 1 addition & 1 deletion charts/tidb-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ rbac:
create: true

# operatorImage is TiDB Operator image
operatorImage: pingcap/tidb-operator:v1.0.0-beta.2
operatorImage: pingcap/tidb-operator:v1.0.0-beta.3
imagePullPolicy: IfNotPresent

defaultStorageClassName: local-storage
Expand Down
2 changes: 1 addition & 1 deletion deploy/gcp/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ variable "tidb_version" {

variable "tidb_operator_version" {
description = "TiDB operator version"
default = "v1.0.0-beta.2"
default = "v1.0.0-beta.3"
}

variable "pd_replica_count" {
Expand Down
4 changes: 2 additions & 2 deletions tests/actions.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func NewOperatorActions(cli versioned.Interface,
const (
DefaultPollTimeout time.Duration = 10 * time.Minute
DefaultPollInterval time.Duration = 1 * time.Minute
BackupAndRestorePollTimeOut time.Duration = 30 * time.Minute
BackupAndRestorePollTimeOut time.Duration = 60 * time.Minute
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a longer restore period.

getBackupDirPodName = "get-backup-dir"
grafanaUsername = "admin"
grafanaPassword = "admin"
Expand Down Expand Up @@ -1921,7 +1921,7 @@ func (oa *operatorActions) CheckScheduledBackup(info *TidbClusterConfig) error {

succededJobCount := 0
for _, j := range backupJobs {
if j.Status.Failed > 0 {
if j.Status.Failed > 3 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the pod may fail one or two times.

return false, fmt.Errorf("cluster [%s/%s] scheduled backup job failed, job: [%s] failed count is: %d",
info.Namespace, info.ClusterName, j.Name, j.Status.Failed)
}
Expand Down
4 changes: 2 additions & 2 deletions tests/manifests/stability/stability.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ spec:
command:
- /usr/local/bin/stability-test
- --config=/etc/tidb-operator-stability/config.yaml
- --operator-image=pingcap/tidb-operator:v1.0.0-beta.2
- --operator-tag=v1.0.0-beta.2
- --operator-image=pingcap/tidb-operator:v1.0.0-beta.3
- --operator-tag=v1.0.0-beta.3
- --slack-webhook-url=""
volumeMounts:
- mountPath: /logDir
Expand Down