filter: update metric schema name #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
changed the title
kennytm
reviewed
Mar 14, 2020
There was a problem hiding this comment.
LGTM after fixing the test.
[2020-03-14T02:16:46.952Z] schema_test.go:49:
[2020-03-14T02:16:46.952Z] c.Assert(IsSystemSchema(t.name), Equals, t.expected, Commentf("schema name = %s", t.name))
[2020-03-14T02:16:46.952Z] ... obtained bool = false
[2020-03-14T02:16:46.952Z] ... expected bool = true
[2020-03-14T02:16:46.952Z] ... schema name = METRIC_SCHEMA
|
The rename was introduced by pingcap/tidb#14874. Temporarily marking it DNM until we confirm if TiDB really wants to break compatibility between 3.x and 4.x. |
|
TiDB 3.0 and 3.1 don't have this schema, so it's safe to rename it. |
|
Seems to be accidentally cherry-picked by pingcap/tidb#14202? @wjhuang2016 Perhaps remove their definitions from 3.0 and 3.1 to avoid accidental usage? |
|
@lonng PTAL |
kennytm
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
https://github.com/pingcap/tidb/blob/6c67561ee0df8c8aed205d0c26eff6ed3bedd3a4/util/misc.go#L150
Current tidb uses
METRICS_SCHEMAinstead ofMETRIC_SCHEMA.What is changed and how it works?
Update metrics schema name.
Check List
Tests
Side effects