lightning: fix an incorrect metric (#52111)

close #51947
pingcap · Mar 27, 2024 · e925628 · e925628
1 parent b96f081
commit e925628
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/br/pkg/lightning/backend/external/engine.go b/br/pkg/lightning/backend/external/engine.go
@@ -327,6 +327,7 @@ func (e *Engine) loadBatchRegionData(ctx context.Context, startKey, endKey []byt
 	e.memKVsAndBuffers.keys = nil
 	e.memKVsAndBuffers.values = nil
 	e.memKVsAndBuffers.memKVBuffers = nil
+	e.memKVsAndBuffers.size = 0
 
 	sendFn := func(dr common.DataAndRange) error {
 		select {

diff --git a/br/pkg/lightning/backend/external/merge_v2.go b/br/pkg/lightning/backend/external/merge_v2.go
@@ -159,6 +159,7 @@ func MergeOverlappingFilesV2(
 		loaded.keys = nil
 		loaded.values = nil
 		loaded.memKVBuffers = nil
+		loaded.size = 0
 
 		if len(endKeyOfGroup) == 0 {
 			break

diff --git a/br/pkg/lightning/backend/external/reader.go b/br/pkg/lightning/backend/external/reader.go
@@ -190,7 +190,7 @@ func readOneFile(
 	output.mu.Lock()
 	output.keysPerFile = append(output.keysPerFile, keys)
 	output.valuesPerFile = append(output.valuesPerFile, values)
-	output.size = size
+	output.size += size
 	output.droppedSizePerFile = append(output.droppedSizePerFile, droppedSize)
 	output.mu.Unlock()
 	return nil