-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix an incorrect metric #52111
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52111 +/- ##
=================================================
- Coverage 70.6704% 54.7283% -15.9422%
=================================================
Files 1486 1599 +113
Lines 439434 610726 +171292
=================================================
+ Hits 310550 334240 +23690
- Misses 109365 253275 +143910
- Partials 19519 23211 +3692
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -63,6 +63,8 @@ func readAllData( | |||
task.End(zap.ErrorLevel, err) | |||
}() | |||
|
|||
output.size = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to move to ⬇️
tidb/br/pkg/lightning/backend/external/engine.go
Lines 326 to 329 in bd17acd
// release the reference of e.memKVsAndBuffers | |
e.memKVsAndBuffers.keys = nil | |
e.memKVsAndBuffers.values = nil | |
e.memKVsAndBuffers.memKVBuffers = nil |
resetting these fields in one place
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #51947
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.