Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for br/pkg/backup #28164

Closed
Tracked by #27178
tisonkun opened this issue Sep 17, 2021 · 3 comments · Fixed by #31288
Closed
Tracked by #27178

migrate test-infra to testify for br/pkg/backup #28164

tisonkun opened this issue Sep 17, 2021 · 3 comments · Fixed by #31288
Assignees
@tisonkun
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Sep 17, 2021
Closed
21 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 17, 2021
@tisonkun
Copy link
Contributor Author

@kennytm @3pointer I try to migrate this package but fail on handling goroutine leaks. Would you take a look on this task? I'm afraid a newcomer can hardly handle it.

@tisonkun tisonkun removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 13, 2021
@tisonkun
Copy link
Contributor Author

cc @YuJuncen

YuJuncen added a commit to YuJuncen/tidb that referenced this issue Oct 25, 2021
@YuJuncen
fix pingcap#28164: adapt testify for backup
86389c7
@YuJuncen YuJuncen mentioned this issue Oct 25, 2021
Closed
1 task
@tisonkun
Copy link
Contributor Author

tisonkun commented Jan 4, 2022

/assign

@tisonkun tisonkun mentioned this issue Jan 4, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jan 23, 2022
@tisonkun
br/pkg/backup: migrate test-infra to testify (#31288)
701f126 
close #28164
YuJuncen pushed a commit to pingcap/br that referenced this issue Mar 1, 2022
@tisonkun
br/pkg/backup: migrate test-infra to testify (#31288)
a1ce222 
close pingcap/tidb#28164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tisonkun tisonkun

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
1 participant
@tisonkun