Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: adapt testify for backup_test #29076

Closed
wants to merge 1 commit into from
Closed

br: adapt testify for backup_test #29076

wants to merge 1 commit into from

Conversation

YuJuncen
Copy link
Contributor

What problem does this PR solve?

Issue Number: fix #28164

Problem Summary:

What is changed and how it works?

Adapt new test-infra for backup_test.

Check List

Tests

  • No code (who test tests?)

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2021
@YuJuncen
Copy link
Contributor Author

/hold not that package!

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2021
feitian124
feitian124 reviewed Oct 28, 2021
View reviewed changes
br/pkg/task/backup_test.go
c.Assert(err, IsNil)
c.Assert(int(ts), Equals, 0)
require.NoError(t, err)
require.Equal(t, int(ts), 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual and expect should swap

feitian124
feitian124 reviewed Oct 28, 2021
View reviewed changes
br/pkg/task/backup_test.go
c.Assert(err, IsNil)
c.Assert(int(ts), Equals, 400036290571534337)
require.NoError(t, err)
require.Equal(t, int(ts), 400036290571534337)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

feitian124
feitian124 reviewed Oct 28, 2021
View reviewed changes
br/pkg/task/backup_test.go
c.Assert(err, IsNil)
c.Assert(int(ts), Equals, 400032515489792000-(offset*1000)<<18)
require.NoError(t, err)
require.Equal(t, int(ts), 400032515489792000-(offset*1000)<<18)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@feitian124
Copy link
Contributor

feitian124 commented Oct 28, 2021 •
edited
Loading

comment inline.
the issue number is not correct.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2021
@ti-chi-bot
Copy link
Member

@YuJuncen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tisonkun
Copy link
Contributor

tisonkun commented Jan 4, 2022

Closed as resolved in #30605.

@tisonkun tisonkun closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feitian124 feitian124 feitian124 left review comments

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for br/pkg/backup
4 participants
@YuJuncen @ti-chi-bot @feitian124 @tisonkun