Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parameter Name from 'tikv-importer.incremental-import' to 'tikv-importer.parallel-import' #45501

Closed
Frank945946 opened this issue Jul 21, 2023 · 0 comments · Fixed by #45539
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@Frank945946
Copy link

Frank945946 commented Jul 21, 2023

Background

The actual meaning of 'tikv-importer.incremental-import' is to use the physical import mode for parallel import, which requires the target table to be empty. However, the current name may mislead users into thinking it is for incremental import, leading to misuse.
When the user misuses it and sets the 'duplicate-resolution' to 'remove', conflicts between data in the source file and the existing data in the target table can lead to the mistaken deletion of the conflicting records in the target table.

Enhancement

  1. Starting from version 7.3, the parameter name has been changed from 'tikv-importer.incremental-import' to 'tikv-importer.parallel-import'.
  2. If users pass the parameter name as 'tikv-importer.incremental-import', it will be converted to 'tikv-importer.parallel-import' for compatibility.

This improvement makes the functionality clearer and helps prevent user misuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
2 participants