Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning: Update Parameter Name from tikv-importer.incremental-import to tikv-importer.parallel-import #45539

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

lyzx2001
Copy link
Contributor

@lyzx2001 lyzx2001 commented Jul 24, 2023

What problem does this PR solve?

Issue Number: close #45501

Problem Summary:

The actual meaning of tikv-importer.incremental-import is to use the physical import mode for parallel import, which requires the target table to be empty. However, the current name may mislead users into thinking it is for incremental import, leading to misuse.
When the user misuses it and sets the duplicate-resolution to remove, conflicts between data in the source file and the existing data in the target table can lead to the mistaken deletion of the conflicting records in the target table.

What is changed and how it works?

  1. Starting from version 7.3, the parameter name has been changed from tikv-importer.incremental-import to tikv-importer.parallel-import.
  2. If users pass the parameter name as tikv-importer.incremental-import, it will be converted to tikv-importer.parallel-import for compatibility.

Since there exist multiple unit tests and integration tests that have covered test cases of tikv-importer.incremental-import, I changed some of them to tikv-importer.parallel-import, and let others remain as tikv-importer.incremental-import. If all of the related unit tests and integration tests can pass, that means the functionality of both tikv-importer.parallel-import and tikv-importer.incremental-import work well.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Parameter name `tikv-importer.incremental-import` has been updated to `tikv-importer.parallel-import`. The meaning of this parameter is to use the physical import mode for parallel import, which requires the target table to be empty.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2023
@lyzx2001
Copy link
Contributor Author

/cc @lance6716

@ti-chi-bot ti-chi-bot bot requested a review from lance6716 July 24, 2023 13:33
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #45539 (37ea222) into master (2eb698c) will increase coverage by 0.6598%.
Report is 19 commits behind head on master.
The diff coverage is 60.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45539        +/-   ##
================================================
+ Coverage   73.2247%   73.8845%   +0.6598%     
================================================
  Files          1265       1272         +7     
  Lines        389531     395842      +6311     
================================================
+ Hits         285233     292466      +7233     
+ Misses        86009      85195       -814     
+ Partials      18289      18181       -108     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.8772% <60.0000%> (+0.6525%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0554% <ø> (ø)
br 52.1743% <60.0000%> (+0.0544%) ⬆️

@lance6716
Copy link
Contributor

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jul 25, 2023

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jul 25, 2023

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyzx2001 lyzx2001 requested a review from lance6716 July 25, 2023 08:33
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 26, 2023
@lyzx2001
Copy link
Contributor Author

/cc @D3Hunter

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-26 03:01:36.669357729 +0000 UTC m=+323439.263888705: ☑️ agreed by lance6716.
  • 2023-07-26 06:24:42.14898032 +0000 UTC m=+335624.743511308: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 1d762be into pingcap:master Jul 26, 2023
12 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Parameter Name from 'tikv-importer.incremental-import' to 'tikv-importer.parallel-import'
3 participants