-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning: Update Parameter Name from tikv-importer.incremental-import
to tikv-importer.parallel-import
#45539
Conversation
…t' to 'tikv-importer.parallel-import'
…rt' to 'tikv-importer.parallel-import'
/cc @lance6716 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45539 +/- ##
================================================
+ Coverage 73.2247% 73.8845% +0.6598%
================================================
Files 1265 1272 +7
Lines 389531 395842 +6311
================================================
+ Hits 285233 292466 +7233
+ Misses 86009 85195 -814
+ Partials 18289 18181 -108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test pull-br-integration-test |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rt' to 'tikv-importer.parallel-import'
…rt' to 'tikv-importer.parallel-import'
…rt' to 'tikv-importer.parallel-import'
/test pull-br-integration-test |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @D3Hunter |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #45501
Problem Summary:
The actual meaning of
tikv-importer.incremental-import
is to use the physical import mode for parallel import, which requires the target table to be empty. However, the current name may mislead users into thinking it is for incremental import, leading to misuse.When the user misuses it and sets the
duplicate-resolution
toremove
, conflicts between data in the source file and the existing data in the target table can lead to the mistaken deletion of the conflicting records in the target table.What is changed and how it works?
tikv-importer.incremental-import
totikv-importer.parallel-import
.tikv-importer.incremental-import
, it will be converted totikv-importer.parallel-import
for compatibility.Since there exist multiple unit tests and integration tests that have covered test cases of
tikv-importer.incremental-import
, I changed some of them totikv-importer.parallel-import
, and let others remain astikv-importer.incremental-import
. If all of the related unit tests and integration tests can pass, that means the functionality of bothtikv-importer.parallel-import
andtikv-importer.incremental-import
work well.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.