Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disttask: task state can't transform from canceling to reverted. #46261

Closed
ywqzzy opened this issue Aug 21, 2023 · 0 comments · Fixed by #46259
Closed

Disttask: task state can't transform from canceling to reverted. #46261

ywqzzy opened this issue Aug 21, 2023 · 0 comments · Fixed by #46259
Labels
component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@ywqzzy
Copy link
Contributor

ywqzzy commented Aug 21, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

func TestFrameworkCancelThenSubmitSubTask(t *testing.T) {
	defer dispatcher.ClearTaskFlowHandle()
	defer scheduler.ClearSchedulers()
	var m sync.Map
	RegisterTaskMeta(&m)
	distContext := testkit.NewDistExecutionContext(t, 3)
	require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/disttask/framework/dispatcher/cancelBeforeUpdate", "1*return(true)"))
	DispatchTaskAndCheckFail("😊", t, &m)
	require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/disttask/framework/dispatcher/cancelBeforeUpdate"))
	distContext.Close()
}

2. What did you expect to see? (Required)

Task failed.

3. What did you see instead (Required)

Task hang.

4. What is your TiDB version? (Required)

master.

@ywqzzy ywqzzy added the type/bug The issue is confirmed as a bug. label Aug 21, 2023
@jebter jebter added severity/major component/ddl This issue is related to DDL of TiDB. labels Aug 21, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Aug 21, 2023
@xhebox xhebox removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants