Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GetSessionVars and Value/GetValue in expression.BuildContext #52366

Closed
lcwangchao opened this issue Apr 7, 2024 · 0 comments · Fixed by #52367, #52468 or #52528
Closed

Remove GetSessionVars and Value/GetValue in expression.BuildContext #52366

lcwangchao opened this issue Apr 7, 2024 · 0 comments · Fixed by #52367, #52468 or #52528
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Apr 7, 2024 •
edited
Loading

Enhancement

It's better to remove some methods like Value, SetValue or GetSessionVars in expression.BuildContext because these methods are too common and contain too many fields even they are not used in BuildContext. These methods makes it's hard to mock or build a standalone context without a session enviroment.
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Apr 7, 2024
@lcwangchao lcwangchao mentioned this issue Apr 7, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 9, 2024
@lcwangchao
expression: add some methods in BuildContext to read fields in Sess…
1905e89 
…ionVars before (#52367)

close #52366
This was referenced Apr 9, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Apr 9, 2024
@lcwangchao
expression: Move more methods from SessionVars to BuildContext (#…
fab13af 
…52440)

ref #52366
@lcwangchao lcwangchao mentioned this issue Apr 10, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
@lcwangchao
expression: BuildContext read location from EvalContext instead o…
da0de56 
…f `SessionVars` (#52451)

ref #52366
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
@lcwangchao
expression: create a new context in ColumnInfos2ColumnsAndNames to …
2debbed 
…ignore truncate error (#52468)

close #52366
@lcwangchao lcwangchao mentioned this issue Apr 12, 2024
Merged
13 tasks
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this issue Apr 16, 2024
@lcwangchao @3AceShowHand
expression: Move more methods from SessionVars to BuildContext (p…
def8c11 
…ingcap#52440)

ref pingcap#52366
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this issue Apr 16, 2024
@lcwangchao @3AceShowHand
expression: BuildContext read location from EvalContext instead o…
eaa6926 
…f `SessionVars` (pingcap#52451)

ref pingcap#52366
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this issue Apr 16, 2024
@lcwangchao @3AceShowHand
expression: create a new context in ColumnInfos2ColumnsAndNames to …
41273be 
…ignore truncate error (pingcap#52468)

close pingcap#52366
ti-chi-bot bot pushed a commit that referenced this issue Apr 17, 2024
@lcwangchao
expression: Add InInsertOrUpdate in BuildContext and remove `GetS…
4ab889c 
…essionVars` (#52528)

close #52366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@lcwangchao