Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: create a new context in ColumnInfos2ColumnsAndNames to ignore truncate error #52468

Merged
merged 1 commit into from
Apr 11, 2024
Merged

expression: create a new context in ColumnInfos2ColumnsAndNames to ignore truncate error #52468

merged 1 commit into from
Apr 11, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #52366

Problem Summary:

Before this PR, ColumnInfos2ColumnsAndNames is not thread-safe because it will modify the inner state of context to force ignore truncate error. It's better to make it thread-safe and remove calls of GetSessionVars in it.

What changed and how does it work?

Add ignoreTruncateExprCtx to ignore the truncate error and make ColumnInfos2ColumnsAndNames thread safe

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
@tiprow tiprow
Copy link

tiprow bot commented Apr 10, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
lcwangchao
lcwangchao commented Apr 10, 2024
View reviewed changes
pkg/executor/executor.go
Comment on lines -934 to -940
// See the comment of `ColumnInfos2ColumnsAndNames`. It's fixing #42341
originalTypeFlags := e.Ctx().GetSessionVars().StmtCtx.TypeFlags()
defer func() {
e.Ctx().GetSessionVars().StmtCtx.SetTypeFlags(originalTypeFlags)
}()
e.Ctx().GetSessionVars().StmtCtx.SetTypeFlags(originalTypeFlags.WithIgnoreTruncateErr(true))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed anymore because ColumnInfos2ColumnsAndNames is thread-safe

YangKeao
YangKeao approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 10, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #52468 (38029e6) into master (312b69f) will increase coverage by 1.1001%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #52468        +/-   ##
================================================
+ Coverage   72.2371%   73.3372%   +1.1001%     
================================================
  Files          1467       1467                
  Lines        426991     427976       +985     
================================================
+ Hits         308446     313866      +5420     
+ Misses        99430      94604      -4826     
- Partials      19115      19506       +391
Flag Coverage Δ
integration 46.0812% <100.0000%> (?)
unit 70.9992% <100.0000%> (-0.1292%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 40.1445% <ø> (-0.9808%) ⬇️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-10 04:57:27.712269468 +0000 UTC m=+1024709.239810013: ☑️ agreed by YangKeao.
  • 2024-04-11 06:38:35.739883621 +0000 UTC m=+1117177.267424167: ☑️ agreed by XuHuaiyu.

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #52468 (38029e6) into master (312b69f) will increase coverage by 1.2898%.
Report is 9 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #52468        +/-   ##
================================================
+ Coverage   72.2371%   73.5270%   +1.2898%     
================================================
  Files          1467       1489        +22     
  Lines        426991     436120      +9129     
================================================
+ Hits         308446     320666     +12220     
+ Misses        99430      95333      -4097     
- Partials      19115      20121      +1006
Flag Coverage Δ
integration 48.6573% <100.0000%> (?)
unit 70.9992% <100.0000%> (-0.1292%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 40.1673% <ø> (-0.9581%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit 2debbed into pingcap:master Apr 11, 2024
24 checks passed
@lcwangchao lcwangchao deleted the ignore_truncate_ctx branch April 11, 2024 08:32
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request Apr 16, 2024
@lcwangchao @3AceShowHand
expression: create a new context in ColumnInfos2ColumnsAndNames to …
41273be 
…ignore truncate error (pingcap#52468)

close pingcap#52366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove GetSessionVars and Value/GetValue in expression.BuildContext
3 participants
@lcwangchao @YangKeao @XuHuaiyu