-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: record slow-log when log use error level #12359
executor: record slow-log when log use error level #12359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12359 +/- ##
===========================================
Coverage 80.8468% 80.8468%
===========================================
Files 454 454
Lines 99900 99900
===========================================
Hits 80766 80766
Misses 13335 13335
Partials 5799 5799 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@lysu merge failed. |
/run-all-tests |
cherry pick to release-2.1 in PR #12373 |
cherry pick to release-3.1 in PR #12375 |
cherry pick to release-3.0 in PR #12377 |
What problem does this PR solve?
when TiDB uses ERROR log level, slow-log will not be output.
What is changed and how it works?
record slow-log even if use ERROR
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is