Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: record slow-log when log use error level (#12359) #12377

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 25, 2019

cherry-pick #12359 to release-3.0


What problem does this PR solve?

when TiDB uses ERROR log level, slow-log will not be output.

What is changed and how it works?

record slow-log even if use ERROR

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

Release note

  • executor: record slow-log when log use error level

This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 25, 2019

/run-all-tests

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Sep 25, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 25, 2019

Your auto merge job has been accepted, waiting for 12373, 12375

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 25, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 25, 2019
@sre-bot sre-bot merged commit 7c48202 into pingcap:release-3.0 Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants