Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: reset NotNull flag for schema of Apply and MaxOneRow properly #12419

Merged
merged 2 commits into from
Oct 10, 2019
Merged

planner: reset NotNull flag for schema of Apply and MaxOneRow properly #12419

merged 2 commits into from
Oct 10, 2019

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Fix #12360

What is changed and how it works?

  • for Apply operator, reset the NotNull flag of the columns from inner child when the join type is LeftOuterJoin;
  • for MaxOneRow operator, since it may produce a row of NULL values when its child returns no row, we should remove the NotNull flag from its schema columns;

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

Release note

N/A

@eurekaka eurekaka added sig/planner SIG: Planner type/bugfix This PR fixes a bug. needs-cherry-pick-2.1 labels Sep 26, 2019
@eurekaka
Copy link
Contributor Author

eurekaka commented Oct 9, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #12419 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #12419   +/-   ##
=========================================
  Coverage   80.008%   80.008%           
=========================================
  Files          460       460           
  Lines       103872    103872           
=========================================
  Hits         83106     83106           
  Misses       14716     14716           
  Partials      6050      6050

alivxxx
alivxxx reviewed Oct 10, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 729f3e4 into pingcap:master Oct 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

cherry pick to release-2.1 failed

@sre-bot sre-bot mentioned this pull request Oct 10, 2019
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

cherry pick to release-3.0 in PR #12589

@sre-bot sre-bot mentioned this pull request Oct 10, 2019
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

cherry pick to release-3.1 in PR #12590

@eurekaka eurekaka deleted the ifnull branch October 10, 2019 09:10
@eurekaka eurekaka mentioned this pull request Oct 14, 2019
Merged
eurekaka added a commit to eurekaka/tidb that referenced this pull request Oct 14, 2019
@eurekaka
planner: reset NotNull flag for schema of Apply and MaxOneRow properly (
e427d7a 
pingcap#12419)
eurekaka added a commit to eurekaka/tidb that referenced this pull request Oct 14, 2019
@eurekaka
planner: reset NotNull flag for schema of Apply and MaxOneRow properly (
ed96ebf 
pingcap#12419)
@eurekaka eurekaka mentioned this pull request Oct 14, 2019
Merged
eurekaka added a commit that referenced this pull request Oct 16, 2019
@eurekaka
planner: reset NotNull flag for schema of Apply and MaxOneRow properly (
8d1dfa1 
#12419) (#12694)
eurekaka added a commit that referenced this pull request Oct 16, 2019
@eurekaka
planner: reset NotNull flag for schema of Apply and MaxOneRow properly (
9539aa5 
#12419) (#12692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eliminate IFNull wrongly
4 participants
@eurekaka @sre-bot @qw4990 @alivxxx