Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: reset NotNull flag for schema of Apply and MaxOneRow properly (#12419) #12694

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #12419

Conflict Files:
cmd/explaintest/r/tpch.result

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.0 cherry-pick labels Oct 14, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-3.0 tikv=release-3.0 pd=release-3.0

@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-3.0 tikv=release-3.0 pd=release-3.0

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

Your auto merge job has been accepted, waiting for 12630

@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

@eurekaka merge failed.

@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-3.0 tikv=release-3.0 pd=release-3.0

@eurekaka eurekaka merged commit 8d1dfa1 into pingcap:release-3.0 Oct 16, 2019
@eurekaka eurekaka deleted the pick_reset_30 branch October 16, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants