Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privilege: fix REVOKE privilege check incompatibility with MySQL (#13014) #13306

Merged
merged 9 commits into from
Dec 11, 2019
Merged

privilege: fix REVOKE privilege check incompatibility with MySQL (#13014) #13306

merged 9 commits into from
Dec 11, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 9, 2019

cherry-pick #13014 to release-3.0

What problem does this PR solve?

Originally, execute REVOKE query demand user have SuperPriv, which is incompatibility with MySQL in such case.

create user u1;
create user u2;
grant select on *.* to u1 with grant option.
grant select on *.* to u2;
// login as u1
revoke select on *.* from u2;

TiDB will return error, MySQL is ok.

What is changed and how it works?

change privilege check for REVOKE like GRANT. If a user has grant option on some object like table or db, he can revoke privilege on these object from other users.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix privilege check for REVOKE

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 9, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Nov 9, 2019
Merged
zz-jason
zz-jason reviewed Nov 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2019
jackysp
jackysp approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

@sre-bot merge failed.

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2019
@zz-jason
Copy link
Member

zz-jason commented Dec 3, 2019

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

Your auto merge job has been accepted, waiting for 13784

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot merge failed.

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

2 similar comments
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

14 similar comments
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 3, 2019

@sre-bot No command or invalid command

@you06
Copy link
Contributor

you06 commented Dec 3, 2019

Terrible bug of bot, fixed.

@jackysp
Copy link
Member

jackysp commented Dec 6, 2019

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 6, 2019

Your auto merge job has been accepted, waiting for 13892, 13932, 13784

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 6, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 6, 2019

@sre-bot merge failed.

@imtbkcat
Copy link

imtbkcat commented Dec 9, 2019

/run-unit-test

@imtbkcat
Copy link

imtbkcat commented Dec 9, 2019

/run-all-tests

@imtbkcat
Copy link

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Dec 11, 2019

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3a10bb8 into pingcap:release-3.0 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
component/privilege status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @zz-jason @you06 @jackysp @imtbkcat @tiancaiamao