-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: fix REVOKE
privilege check incompatibility with MySQL
#13014
Conversation
/run-all-tests tidb-test=pr/932 |
Codecov Report
@@ Coverage Diff @@
## master #13014 +/- ##
===========================================
Coverage 80.3176% 80.3176%
===========================================
Files 469 469
Lines 112278 112278
===========================================
Hits 90179 90179
Misses 15197 15197
Partials 6902 6902 |
/run-all-tests tidb-test=pr/932 |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-3.0 in PR #13306 |
cherry pick to release-3.1 in PR #13307 |
cherry pick to release-2.1 failed |
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @imtbkcat PTAL. |
What problem does this PR solve?
Originally, execute
REVOKE
query demand user haveSuperPriv
, which is incompatibility with MySQL in such case.TiDB will return error, MySQL is ok.
What is changed and how it works?
change privilege check for
REVOKE
likeGRANT
. If a user has grant option on some object like table or db, he can revoke privilege on these object from other users.Check List
Tests
Code changes
Side effects
Related changes
Release note
REVOKE