Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix REVOKE privilege check incompatibility with MySQL #13014

Merged
merged 7 commits into from
Nov 9, 2019

Conversation

imtbkcat
Copy link

What problem does this PR solve?

Originally, execute REVOKE query demand user have SuperPriv, which is incompatibility with MySQL in such case.

create user u1;
create user u2;
grant select on *.* to u1 with grant option.
grant select on *.* to u2;
// login as u1
revoke select on *.* from u2;

TiDB will return error, MySQL is ok.

What is changed and how it works?

change privilege check for REVOKE like GRANT. If a user has grant option on some object like table or db, he can revoke privilege on these object from other users.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix privilege check for REVOKE

@imtbkcat
Copy link
Author

/run-all-tests tidb-test=pr/932

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #13014 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13014   +/-   ##
===========================================
  Coverage   80.3176%   80.3176%           
===========================================
  Files           469        469           
  Lines        112278     112278           
===========================================
  Hits          90179      90179           
  Misses        15197      15197           
  Partials       6902       6902

@imtbkcat
Copy link
Author

/run-all-tests tidb-test=pr/932

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

cherry pick to release-3.0 in PR #13306

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

cherry pick to release-3.1 in PR #13307

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2019

cherry pick to release-2.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @imtbkcat PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants