-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: fix REVOKE
privilege check incompatibility with MySQL (#13014)
#13307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
component/privilege
type/3.1 cherry-pick
type/bugfix
This PR fixes a bug.
type/compatibility
labels
Nov 9, 2019
zz-jason
reviewed
Nov 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jackysp
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jackysp
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Nov 11, 2019
Your auto merge job has been accepted, waiting for 13306 |
/run-all-tests |
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/privilege
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/bugfix
This PR fixes a bug.
type/compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #13014 to release-3.1
What problem does this PR solve?
Originally, execute
REVOKE
query demand user haveSuperPriv
, which is incompatibility with MySQL in such case.TiDB will return error, MySQL is ok.
What is changed and how it works?
change privilege check for
REVOKE
likeGRANT
. If a user has grant option on some object like table or db, he can revoke privilege on these object from other users.Check List
Tests
Code changes
Side effects
Related changes
Release note
REVOKE