config: correct the explanation of status-host #13315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13315 +/- ##
===========================================
Coverage 80.1531% 80.1531%
===========================================
Files 469 469
Lines 112068 112068
===========================================
Hits 89826 89826
Misses 15294 15294
Partials 6948 6948 |
shenli
reviewed
Nov 9, 2019
| @@ -135,12 +135,12 @@ cluster-ssl-key = "" | |||
| # If enable status report HTTP service. | |||
| report-status = true | |||
|
|
|||
| # TiDB status host. | |||
| status-host = "0.0.0.0" | |||
|
|
|||
| ## status-host is the HTTP address for reporting the internal status of a TiDB server, for example: | |||
There was a problem hiding this comment.
This comment is not only for the status-host but also for status-port.
zz-jason
reviewed
Dec 29, 2019
| @@ -135,12 +135,12 @@ cluster-ssl-key = "" | |||
| # If enable status report HTTP service. | |||
| report-status = true | |||
|
|
|||
| # TiDB status host. | |||
| status-host = "0.0.0.0" | |||
|
|
|||
| ## status-host is the HTTP address for reporting the internal status of a TiDB server, for example: | |||
There was a problem hiding this comment.
Suggested change
| ## status-host is the HTTP address for reporting the internal status of a TiDB server, for example: | |
| ## status-host and status-port together specify the HTTP address for reporting the internal status of a TiDB server, for example: |
| ## status-host is the HTTP address for reporting the internal status of a TiDB server, for example: | ||
| ## API for prometheus: http://${status-host}:${status_port}/metrics | ||
| ## API for pprof: http://${status-host}:${status_port}/debug/pprof | ||
| # TiDB status host. |
There was a problem hiding this comment.
Actually TiDB status host only have one more information than status-host, which is tidb... I think we can remove this useless comment. So as the tidb status port comment.
We should explain more about the status-host and status-port in the above comment block.
|
@ericsyh, please update your pull request. |
1 similar comment
|
@ericsyh, please update your pull request. |
|
@ericsyh PR closed due to no update for a long time. Feel free to reopen it anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Revise the PR #13024 which add API example for prometheus and pprof.
What is changed and how it works?
Put the API example to the correct position.
Check List
Tests
Side effects
Related changes