config: correct the explanation of status and metrics. #13024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13024 +/- ##
===========================================
Coverage 80.0635% 80.0635%
===========================================
Files 468 468
Lines 110160 110160
===========================================
Hits 88198 88198
Misses 15187 15187
Partials 6775 6775 |
|
LGTM |
|
cherry pick to release-3.1 in PR #13107 |
|
cherry pick to release-3.0 in PR #13108 |
|
cherry pick to release-2.1 failed |
sre-bot
added a commit
that referenced
this pull request
Nov 5, 2019
sre-bot
added a commit
that referenced
this pull request
Nov 5, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @ericsyh PTAL. |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16179 |
sre-bot
added a commit
that referenced
this pull request
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The explanation of
metrics-addrandstatus-portis not so accurate.status-portcopiedmetrics-addrexplanation which is a mistake, need to remove it.metrics-addrleaves empty will disable the push to Pushgateway, rather than Prometheus push.What is changed and how it works?
status-portstatus-hostandstatus-portmetrics-addrCheck List
Tests
Related changes