Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics,store: add a metric for ttlManager to record the lifetime reach events #14298

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Currently, we limit the pessimistic transaction to finish with 10min. It shouldn't take too long in general.
This commit adds a metric for that kind of event.

What is changed and how it works?

Add a metric.

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@coocood
Copy link
Member

coocood commented Dec 31, 2019

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Dec 31, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2019

@tiancaiamao merge failed.

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2019

cherry pick to release-3.0 in PR #14300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants