Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics,store: add a metric for ttlManager to record the lifetime reach events (#14298) #14300

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 31, 2019

cherry-pick #14298 to release-3.0


What problem does this PR solve?

Currently, we limit the pessimistic transaction to finish with 10min. It shouldn't take too long in general.
This commit adds a metric for that kind of event.

What is changed and how it works?

Add a metric.

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 31, 2019

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jan 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

Your auto merge job has been accepted, waiting for 14190

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

/run-all-tests

@zz-jason zz-jason merged commit 00f0015 into pingcap:release-3.0 Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants