statistics: fix panic when getStatsReader fail
#15651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
added
type/bugfix
ghost
requested review from
francis0407 and
lzmhhh123
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15651 +/- ##
===========================================
Coverage 80.4843% 80.4843%
===========================================
Files 504 504
Lines 134584 134584
===========================================
Hits 108319 108319
Misses 17784 17784
Partials 8481 8481 |
|
How did you find this bug? |
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@winoros merge failed. |
|
/run-integration-common-test |
|
cherry pick to release-3.0 in PR #15709 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
|
cherry pick to release-3.1 in PR #15710 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
|
cherry pick to release-4.0 in PR #15711 |
zz-jason
pushed a commit
that referenced
this pull request
Mar 26, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 30, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The
deferfunc is not placed correctly. Thus it would panic in some cases.What is changed and how it works?
Check the error before the defer func. Avoid potential panic.
Related changes
Check List
Tests