statistics: fix panic when getStatsReader fail (#15651)
#15711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/statistics
type/4.0-cherry-pick
type/bugfix
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 15628, 15635 |
|
/run-all-tests |
|
/merge |
|
Sorry @winoros, you don't have permission to trigger auto merge event on this branch. |
SunRunAway
added
status/can-merge
zz-jason
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15651 to release-4.0
What problem does this PR solve?
The
deferfunc is not placed correctly. Thus it would panic in some cases.What is changed and how it works?
Check the error before the defer func. Avoid potential panic.
Related changes
Check List
Tests