expression: keep xor result consistent with mysql 8 #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
sduzh
changed the title
SunRunAway
added
status/can-merge
|
/run-all-tests |
|
@sduzh merge failed. |
|
Seems like the integration-test needs an update. @SunRunAway |
That's right, I'll do it later. |
|
/run-all-tests |
|
/run-common-test tidb-test=pr/1049 |
Codecov Report
@@ Coverage Diff @@
## master #15934 +/- ##
===========================================
Coverage 79.9868% 79.9868%
===========================================
Files 509 509
Lines 138679 138679
===========================================
Hits 110925 110925
Misses 18798 18798
Partials 8956 8956 |
This comment has been minimized.
This comment has been minimized.
zz-jason
approved these changes
Apr 30, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sduzh merge failed. |
|
/run-common-test tidb-test=pr/1049 |
|
cherry pick to release-3.0 in PR #16976 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 6, 2020
|
cherry pick to release-3.1 in PR #16977 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 6, 2020
|
cherry pick to release-4.0 in PR #16978 |
zz-jason
pushed a commit
that referenced
this pull request
May 13, 2020
SunRunAway
pushed a commit
that referenced
this pull request
May 13, 2020
SunRunAway
pushed a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The 'xor' result is different between tidb and mysql8
Issue Number: close #12867
Problem Summary:
What is changed and how it works?
What's Changed:
Keep xor result consistent with MySQL 8, instead of MySQL 5.7
Related changes
Check List
Tests
Side effects
Release note