Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: keep xor result consistent with mysql 8 (#15934) #16977

Merged
merged 3 commits into from
May 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 6, 2020

cherry-pick #15934 to release-3.1


What problem does this PR solve?

The 'xor' result is different between tidb and mysql8

Issue Number: close #12867

Problem Summary:

What is changed and how it works?

What's Changed:

Keep xor result consistent with MySQL 8, instead of MySQL 5.7

Related changes

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility

Release note

  • keep xor results of float arguments consistent with mysql 8

@sre-bot
Copy link
Contributor Author

sre-bot commented May 6, 2020

/run-all-tests

@SunRunAway
Copy link
Contributor

/run-common-test tidb-test=pr/1052
/run-integration-common-test tidb-test=pr/1052

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented May 7, 2020

@SunRunAway please fix the release note.

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 7, 2020
@SunRunAway
Copy link
Contributor

/rebuild

@bb7133 bb7133 modified the milestones: v3.1.1, v3.1.2 May 9, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

/run-all-tests

@SunRunAway
Copy link
Contributor

/run-common-test tidb-test=pr/1052
/run-integration-common-test tidb-test=pr/1052

@SunRunAway SunRunAway merged commit b8219e6 into pingcap:release-3.1 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants