config: correct the explanation of status and metrics. (#13024) #16179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
zimulala
reviewed
Apr 8, 2020
config/config.toml.example
Outdated
| @@ -128,13 +128,22 @@ cluster-ssl-key = "" | |||
| # If enable status report HTTP service. | |||
| report-status = true | |||
|
|
|||
| <<<<<<< HEAD | |||
| ======= | |||
There was a problem hiding this comment.
Please fix the conflicts. @ericsyh
zimulala
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 16309 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #13024 to release-2.1
What problem does this PR solve?
The explanation of
metrics-addrandstatus-portis not so accurate.status-portcopiedmetrics-addrexplanation which is a mistake, need to remove it.metrics-addrleaves empty will disable the push to Pushgateway, rather than Prometheus push.What is changed and how it works?
status-portstatus-hostandstatus-portmetrics-addrCheck List
Tests
Related changes