-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support GROUP_CONCAT(ORDER BY) #16591
executor: support GROUP_CONCAT(ORDER BY) #16591
Conversation
/build-wasm |
/run-all-tests |
/run-integration-copr-test |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #16591 +/- ##
===========================================
Coverage 80.5162% 80.5162%
===========================================
Files 510 510
Lines 142216 142216
===========================================
Hits 114507 114507
Misses 18760 18760
Partials 8949 8949 |
/run-all-tests |
/run-integration-copr-test |
f15e615
to
a29b92a
Compare
5d00063
to
26fa2e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/run-all-tests |
@SunRunAway merge failed. |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.0 in PR #16988 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-3.1 in PR #16989 |
cherry pick to release-4.0 in PR #16990 |
What problem does this PR solve?
Issue Number: close #6838
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Executor part:
GROUP_CONCAT
function implementation.group_concat
hasORDER BY
clause.Planner part:
ORDER BY
clause.ORDER BY
clause.ORDER BY
clause inResolveIndices
,PruneColumns
andInjectProjBelowAgg
group_concat
hasORDER BY
clause.group_concat
hasORDER BY
clause.How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note