-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support GROUP_CONCAT(ORDER BY) (#16591) #16988
Merged
sre-bot
merged 11 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-7ebcc203986b
May 8, 2020
Merged
executor: support GROUP_CONCAT(ORDER BY) (#16591) #16988
sre-bot
merged 11 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-7ebcc203986b
May 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/execution
SIG execution
component/expression
sig/planner
SIG: Planner
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
status/PTAL
type/3.0-cherry-pick
type/new-feature
labels
May 6, 2020
sre-bot
requested review from
eurekaka,
francis0407,
qw4990,
winoros,
XuHuaiyu and
zz-jason
May 6, 2020 10:45
/run-all-tests |
/run-all-tests |
SunRunAway
added
the
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
label
May 7, 2020
qw4990
reviewed
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winoros
approved these changes
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 8, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/execution
SIG execution
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/new-feature
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16591 to release-3.0
What problem does this PR solve?
Issue Number: close #6838
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Executor part:
GROUP_CONCAT
function implementation.group_concat
hasORDER BY
clause.Planner part:
ORDER BY
clause.ORDER BY
clause.ORDER BY
clause inResolveIndices
,PruneColumns
andInjectProjBelowAgg
group_concat
hasORDER BY
clause.group_concat
hasORDER BY
clause.How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note