Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix the issue that incorrect result for query that uses an AND operator on floats (#15927) #16664

Closed

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 21, 2020

cherry-pick #15927 to release-3.0


What problem does this PR solve?

Issue Number: close #15743, close #16426

What is changed and how it works?

Don't round the value when converting it to bool.

Check List

Tests

  • Unit test

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qw4990 please resolve conflict and fix CI.

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

@sre-bot, please update your pull request.

1 similar comment
@sre-bot
Copy link
Contributor Author

sre-bot commented May 5, 2020

@sre-bot, please update your pull request.

@bb7133 bb7133 modified the milestones: v3.0.14, v3.0.15 May 19, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

@sre-bot PR closed due to no update for a long time. Feel free to reopen it anytime.

@sre-bot sre-bot closed this May 21, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants