expression: fix the issue that incorrect result for query that uses an AND operator on floats #15927

qw4990 · 2020-03-31T13:21:59Z

What problem does this PR solve?

Issue Number: close #15743, close #16426

What is changed and how it works?

Don't round the value when converting it to bool.

Check List

Tests

Unit test

zz-jason

LGTM

zz-jason · 2020-03-31T15:32:11Z

Please fix UT:

datum_test.go:66: testDatumSuite.TestToBool

[2020-03-31T13:24:24.756Z] FAIL: datum_test.go:66: testDatumSuite.TestToBool

[2020-03-31T13:24:24.756Z] 

[2020-03-31T13:24:24.756Z] datum_test.go:70:

[2020-03-31T13:24:24.756Z]     testDatumToBool(c, float32(0.1), 0)

[2020-03-31T13:24:24.756Z] datum_test.go:63:

[2020-03-31T13:24:24.756Z]     c.Assert(b, Equals, res64)

[2020-03-31T13:24:24.756Z] ... obtained int64 = 1

[2020-03-31T13:24:24.756Z] ... expected int64 = 0

codecov · 2020-04-01T07:24:56Z

Codecov Report

Merging #15927 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15927   +/-   ##
===========================================
  Coverage   80.4895%   80.4895%           
===========================================
  Files           506        506           
  Lines        137429     137429           
===========================================
  Hits         110616     110616           
  Misses        18221      18221           
  Partials       8592       8592

zz-jason

LGTM

qw4990 · 2020-04-01T08:25:05Z

/run-all-tests

XuHuaiyu

LGTM

XuHuaiyu · 2020-04-01T08:26:05Z

/merge

qw4990 · 2020-04-01T11:51:39Z

/run-all-tests

qw4990 · 2020-04-02T02:50:35Z

[2020-04-01T11:53:55.438Z] Statement: #839 -  SELECT ATAN( `col_varbinary_32`, ( ROUND( `col_year_key` ) ) ) AS field1, ABS( 8188107072512983040 ) AS field2, - 0 AS field3 FROM `table10_int_autoinc` WHERE LOG( `col_varchar_64_key`, '2033-08-25 07:33:37.038938' ) /* QNO 841 CON_ID 184 */ 
[2020-04-01T11:53:55.438Z] NoPushDown Output: 
[2020-04-01T11:53:55.438Z] field1	field2	field3
[2020-04-01T11:53:55.438Z] 0	8188107072512983040	0
[2020-04-01T11:53:55.438Z] 0	8188107072512983040	0
[2020-04-01T11:53:55.438Z] 0	8188107072512983040	0
[2020-04-01T11:53:55.438Z] 
[2020-04-01T11:53:55.438Z] 
[2020-04-01T11:53:55.438Z] WithPushDown Output: 
[2020-04-01T11:53:55.438Z] field1	field2	fie
[2020-04-01T11:53:55.438Z] 0	8188107072512983040	0

It seems that the coprocessor also has this problem, could you help me to fix it? @zhongzc

zhongzc · 2020-04-02T03:01:44Z

@qw4990 ok

zhongzc · 2020-04-02T03:07:31Z

@qw4990 Seems there're still issues in TiDB.
In MySQL 5.7:

mysql root@127.0.0.1:test> SELECT ATAN( `col_varbinary_32`, ( ROUND( `col_year_key` ) ) ) AS field1, ABS( 8188107072512983040 ) AS field2, - 0 AS field3 FROM `table
                           10_int_autoinc` WHERE LOG( `col_varchar_64_key`, '2033-08-25 07:33:37.038938' ) /* QNO 841 CON_ID 184 */
+--------+---------------------+--------+
| field1 | field2              | field3 |
+--------+---------------------+--------+
| 0.0    | 8188107072512983040 | 0      |
+--------+---------------------+--------+

qw4990 · 2020-04-20T03:23:28Z

Wait for tikv/tikv#7342.

SunRunAway

Should mocktikv be updated?

qw4990 · 2020-04-20T12:22:59Z

/run-integration-copr-test tikv=pr/7342

qw4990 · 2020-04-20T12:31:32Z

/run-all-tests

qw4990 · 2020-04-20T12:32:06Z

/run-integration-copr-test tikv=pr/7342

qw4990 · 2020-04-21T06:26:23Z

/run-all-tests

qw4990 · 2020-04-21T06:31:12Z

/run-integration-copr-test tikv=pr/7342

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-21T06:41:40Z

cherry pick to release-2.1 in PR #16663

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-21T06:42:49Z

cherry pick to release-3.0 in PR #16664

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-21T06:44:06Z

cherry pick to release-3.1 in PR #16665

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-21T06:45:06Z

cherry pick to release-4.0 in PR #16666

fix issue 15743

fbe8290

qw4990 added status/WIP type/bugfix This PR fixes a bug. component/expression labels Mar 31, 2020

qw4990 requested a review from a team as a code owner March 31, 2020 13:22

ghost requested review from SunRunAway and removed request for a team March 31, 2020 13:22

zz-jason reviewed Mar 31, 2020

View reviewed changes

qw4990 added 2 commits April 1, 2020 15:13

fix CI

182b531

Merge remote-tracking branch 'upstream/master' into fix-15743

f45dcc3

qw4990 added needs-cherry-pick-4.0 and removed status/WIP labels Apr 1, 2020

zz-jason reviewed Apr 1, 2020

View reviewed changes

zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2020

qw4990 requested review from Reminiscent and wshwsh12 April 1, 2020 08:12

XuHuaiyu previously approved these changes Apr 1, 2020

View reviewed changes

XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 1, 2020

XuHuaiyu added the needs-cherry-pick-3.1 label Apr 1, 2020

qw4990 added the needs-cherry-pick-2.1 label Apr 1, 2020

ngaut removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2020

SunRunAway reviewed Apr 20, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into fix-15743

151e786

qw4990 force-pushed the fix-15743 branch from c8d68dd to 151e786 Compare April 21, 2020 06:26

SunRunAway approved these changes Apr 21, 2020

View reviewed changes

SunRunAway merged commit 94011e6 into pingcap:master Apr 21, 2020

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 21, 2020

cherry pick pingcap#15927 to release-2.1

1542d7a

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 21, 2020

expression: fix the issue that incorrect result for query that uses an AND operator on floats (#15927) #16663

Closed

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 21, 2020

cherry pick pingcap#15927 to release-3.0

60b7c2e

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 21, 2020

expression: fix the issue that incorrect result for query that uses an AND operator on floats (#15927) #16664

Closed

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 21, 2020

cherry pick pingcap#15927 to release-3.1

026d5b6

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 21, 2020

expression: fix the issue that incorrect result for query that uses an AND operator on floats (#15927) #16665

Closed

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 21, 2020

cherry pick pingcap#15927 to release-4.0

4eb806e

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 21, 2020

expression: fix the issue that incorrect result for... (#15927) #16666

Merged

zz-jason pushed a commit that referenced this pull request May 4, 2020

expression: fix the issue that incorrect result for... (#15927) (#16666)

acc1c5a

wjhuang2016 mentioned this pull request May 17, 2020

P1-[4.0 bug hunting]-[WHERE Clause]-Wrong evaluation of binary operator tidb-challenge-program/bug-hunting-issue#68

Open

ichn-hu mentioned this pull request Nov 26, 2020

P1-[4.0 bug hunting]-[WHERE Clause]-Wrong evaluation of binary operator #17757

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: fix the issue that incorrect result for query that uses an AND operator on floats #15927

expression: fix the issue that incorrect result for query that uses an AND operator on floats #15927

qw4990 commented Mar 31, 2020 •

edited

Loading

zz-jason left a comment

zz-jason commented Mar 31, 2020 •

edited

Loading

codecov bot commented Apr 1, 2020 •

edited

Loading

zz-jason left a comment

qw4990 commented Apr 1, 2020

XuHuaiyu left a comment

XuHuaiyu commented Apr 1, 2020

qw4990 commented Apr 1, 2020

qw4990 commented Apr 2, 2020

zhongzc commented Apr 2, 2020

zhongzc commented Apr 2, 2020 •

edited

Loading

qw4990 commented Apr 20, 2020

SunRunAway left a comment

qw4990 commented Apr 20, 2020

qw4990 commented Apr 20, 2020

qw4990 commented Apr 20, 2020

qw4990 commented Apr 21, 2020

qw4990 commented Apr 21, 2020

sre-bot commented Apr 21, 2020

sre-bot commented Apr 21, 2020

sre-bot commented Apr 21, 2020

sre-bot commented Apr 21, 2020

expression: fix the issue that incorrect result for query that uses an AND operator on floats #15927

expression: fix the issue that incorrect result for query that uses an AND operator on floats #15927

Conversation

qw4990 commented Mar 31, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

zz-jason left a comment

Choose a reason for hiding this comment

zz-jason commented Mar 31, 2020 • edited Loading

codecov bot commented Apr 1, 2020 • edited Loading

Codecov Report

zz-jason left a comment

Choose a reason for hiding this comment

qw4990 commented Apr 1, 2020

XuHuaiyu left a comment

Choose a reason for hiding this comment

XuHuaiyu commented Apr 1, 2020

qw4990 commented Apr 1, 2020

qw4990 commented Apr 2, 2020

zhongzc commented Apr 2, 2020

zhongzc commented Apr 2, 2020 • edited Loading

qw4990 commented Apr 20, 2020

SunRunAway left a comment

Choose a reason for hiding this comment

qw4990 commented Apr 20, 2020

qw4990 commented Apr 20, 2020

qw4990 commented Apr 20, 2020

qw4990 commented Apr 21, 2020

qw4990 commented Apr 21, 2020

sre-bot commented Apr 21, 2020

sre-bot commented Apr 21, 2020

sre-bot commented Apr 21, 2020

sre-bot commented Apr 21, 2020

qw4990 commented Mar 31, 2020 •

edited

Loading

zz-jason commented Mar 31, 2020 •

edited

Loading

codecov bot commented Apr 1, 2020 •

edited

Loading

zhongzc commented Apr 2, 2020 •

edited

Loading