expression: fix the issue that incorrect result for... (#15927) #16666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/expression
status/require-change
type/4.0-cherry-pick
type/bugfix
ghost
requested a review
from 
|
@sre-bot, please update your pull request. |
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests tikv=pr/7583 |
|
Conflicts have been resolved, PTAL @zz-jason @SunRunAway @breeswish @zhongzc |
zhongzc
approved these changes
May 4, 2020
zz-jason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15927 to release-4.0
What problem does this PR solve?
Issue Number: close #15743, close #16426
What is changed and how it works?
Don't round the value when converting it to
bool.Check List
Tests