Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check full match of each range for BatchPointGet plan #19456

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #19191

Problem Summary:

Planner chooses BatchPointGet plan while it should not.

What is changed and how it works?

What's Changed:
Check whether each range is a full match for the unique index before considering BatchPointGet plan.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • fix wrong result caused by mistaken usage of batch point get.

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-4.0 labels Aug 26, 2020
@eurekaka eurekaka requested a review from a team as a code owner August 26, 2020 03:59
@eurekaka eurekaka requested review from XuHuaiyu and removed request for a team August 26, 2020 03:59
@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@eurekaka merge failed.

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19460

@eurekaka eurekaka deleted the wrong_res_batch_point branch August 26, 2020 06:19
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Aug 26, 2020
… (#19460)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong result caused by misuse of batch-point-get
4 participants