-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: check full match of each range for BatchPointGet plan (#19456) #19460
Merged
ti-srebot
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-ef51ea8befba
Aug 26, 2020
Merged
planner: check full match of each range for BatchPointGet plan (#19456) #19460
ti-srebot
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-ef51ea8befba
Aug 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
ti-srebot
added
sig/planner
SIG: Planner
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
eurekaka
force-pushed
the
release-4.0-ef51ea8befba
branch
from
August 26, 2020 06:32
09d18cd
to
c1ca48f
Compare
lzmhhh123
reviewed
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XuHuaiyu
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 26, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 26, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19456 to release-4.0
What problem does this PR solve?
Issue Number: close #19191
Problem Summary:
Planner chooses BatchPointGet plan while it should not.
What is changed and how it works?
What's Changed:
Check whether each range is a full match for the unique index before considering BatchPointGet plan.
Related changes
Check List
Tests
Side effects
N/A
Release note