Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix index merge doesn't take effect when using prefix key #20425

Merged
merged 16 commits into from
Nov 12, 2020
Merged

planner: fix index merge doesn't take effect when using prefix key #20425

merged 16 commits into from
Nov 12, 2020

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Oct 13, 2020

What problem does this PR solve?

Issue Number: close #16407

Problem Summary:

Index merge doesn't take effect when using prefix key.

What is changed and how it works?

The condition tableFilter is not empty is too strict.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • None

Release note

  • None

@tangwz tangwz requested a review from a team as a code owner October 13, 2020 08:02
@tangwz tangwz requested review from eurekaka and removed request for a team October 13, 2020 08:02
@tangwz tangwz changed the title (WIP)planner: fix index merge doesn't take effect when using prefix key planner[WIP]: fix index merge doesn't take effect when using prefix key Oct 13, 2020
@tangwz tangwz changed the title planner[WIP]: fix index merge doesn't take effect when using prefix key planner: fix index merge doesn't take effect when using prefix key Oct 13, 2020
@qw4990 qw4990 self-requested a review October 14, 2020 02:31
@qw4990 qw4990 added the sig/planner SIG: Planner label Oct 15, 2020
@winoros winoros added the type/enhancement The issue or PR belongs to an enhancement. label Oct 15, 2020
eurekaka
eurekaka reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
time-and-fate
time-and-fate reviewed Nov 5, 2020
View reviewed changes
planner/core/stats.go Outdated Show resolved Hide resolved
@time-and-fate
Copy link
Member

LGTM

@ti-srebot
Copy link
Contributor

@time-and-fate, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: planner(slack).

qw4990
qw4990 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 6, 2020
@qw4990
Copy link
Contributor

qw4990 commented Nov 6, 2020

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Nov 10, 2020

/run-all-tests

@time-and-fate
Copy link
Member

/run-check_dev_2

@zz-jason
Copy link
Member

it's better to cherry-pick to release-4.0 as well.

@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 12, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20964
  • 20521
  • 20948

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 5a14eb5 into pingcap:master Nov 12, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 12, 2020
@tangwz @ti-srebot
cherry pick pingcap#20425 to release-4.0
fe9217d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 12, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21003

qw4990 pushed a commit that referenced this pull request Nov 30, 2020
@ti-srebot
planner: fix index merge doesn't take effect when using prefix key (#…
eab4476 
…20425) (#21003)
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 31, 2020
Closed
@eurekaka eurekaka mentioned this pull request Dec 31, 2020
Merged
@wjhuang2016 wjhuang2016 mentioned this pull request Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index merge doesn't take effect when using prefix key
7 participants
@tangwz @time-and-fate @ti-srebot @qw4990 @zz-jason @eurekaka @winoros