planner: avoid using index_merge when there are multiple table filters #22122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
XuHuaiyu
requested review from
eurekaka and
lzmhhh123
and removed request for
a team
|
/run-all-tests |
eurekaka
reviewed
Dec 31, 2020
| for _, path := range partialPaths { | ||
| // IndexMerge should not be used when the SQL is like 'select x from t WHERE (key1=1 AND key2=2) OR (key1=4 AND key3=6);'. | ||
| // Check issue https://github.com/pingcap/tidb/issues/22105 for details. |
There was a problem hiding this comment.
Actually we can use IndexMerge for this case, as long as we keep the whole filter (key1=1 and key2=2) or (key1=4 and key3=6) in the selection, that should be the original intention of #20425.
eurekaka
reviewed
Dec 31, 2020
XuHuaiyu
force-pushed
the
issue/22105
branch
from
1063970
to
5218556
Compare
|
/run-all-tests |
XuHuaiyu
added
status/LGT2
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 31, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #22124 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 31, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0-rc in PR #22125 |
qw4990
pushed a commit
that referenced
this pull request
Dec 31, 2020
eurekaka
pushed a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #22105
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Avoid using index merge when there are multiple table filters.
How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note