Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, planner: make partition table consider collation in create table and select sentence #20937

Merged
merged 11 commits into from
Nov 21, 2020
Merged

ddl, planner: make partition table consider collation in create table and select sentence #20937

merged 11 commits into from
Nov 21, 2020
+88 −13

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #20879

Problem Summary:

partition table does not consider collation in create table and select sentence.

Check List

Tests

  • Unit test

Release note

  • fix a bug that partition table does not consider collation in create table and select sentence.

@xiongjiwei xiongjiwei marked this pull request as ready for review November 9, 2020 09:12
@xiongjiwei xiongjiwei requested a review from a team as a code owner November 9, 2020 09:12
@xiongjiwei xiongjiwei requested review from hanfei1991 and removed request for a team November 9, 2020 09:12
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Nov 9, 2020
wjhuang2016
wjhuang2016 reviewed Nov 10, 2020
View reviewed changes
ddl/db_partition_test.go Outdated Show resolved Hide resolved
planner/core/partition_pruning_test.go Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei xiongjiwei marked this pull request as draft November 10, 2020 11:51
@ichn-hu ichn-hu mentioned this pull request Nov 16, 2020
Closed
@xiongjiwei xiongjiwei marked this pull request as ready for review November 20, 2020 04:14
bb7133
bb7133 reviewed Nov 20, 2020
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
planner/core/rule_partition_processor.go Outdated Show resolved Hide resolved
bb7133
bb7133 reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2020
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

wjhuang2016
wjhuang2016 reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 20, 2020
@wjhuang2016
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@bb7133
Copy link
Member

bb7133 commented Nov 21, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit fbaab3e into pingcap:master Nov 21, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 21, 2020
@xiongjiwei @ti-srebot
cherry pick pingcap#20937 to release-4.0
4b114e6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 21, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21181

@xiongjiwei xiongjiwei deleted the bug-20879 branch November 21, 2020 07:15
ti-srebot added a commit that referenced this pull request Nov 23, 2020
@ti-srebot
ddl, planner: make partition table consider collation in create table…
5c1aa3c 
… and select sentence (#20937) (#21181)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@xiongjiwei xiongjiwei mentioned this pull request Nov 23, 2020
Merged
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@AilinKid AilinKid AilinKid left review comments

@tiancaiamao tiancaiamao tiancaiamao left review comments

@bb7133 bb7133 bb7133 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partition table doesn't consider collation
6 participants
@xiongjiwei @tiancaiamao @ti-srebot @wjhuang2016 @bb7133 @AilinKid