Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: compare expression in check partition definition according to column type #21226

Merged
merged 6 commits into from
Nov 25, 2020
Merged

ddl: compare expression in check partition definition according to column type #21226

merged 6 commits into from
Nov 25, 2020

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Nov 23, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #21227
close #21225

Problem Summary:

it is a patch of #20937, we cannot compare datetime, date, time type column as string type

Check List

Tests

  • Unit test

Release note

  • fix a bug that checks partition definition according to column type

@xiongjiwei xiongjiwei marked this pull request as ready for review November 23, 2020 12:11
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Nov 23, 2020
@bb7133
Copy link
Member

bb7133 commented Nov 23, 2020

PTAL @tiancaiamao @crazycs520

@xiongjiwei xiongjiwei requested a review from a team as a code owner November 24, 2020 03:25
@xiongjiwei xiongjiwei requested review from hanfei1991 and removed request for a team November 24, 2020 03:25
crazycs520
crazycs520 reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2020
@ichn-hu ichn-hu mentioned this pull request Nov 24, 2020
Closed
@bb7133
Copy link
Member

bb7133 commented Nov 25, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@zhouqiang-cl
Copy link
Contributor

/run-integration-compatibility-test

@wjhuang2016 wjhuang2016 merged commit f4e58ee into pingcap:master Nov 25, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 25, 2020
@xiongjiwei @ti-srebot
cherry pick pingcap#21226 to release-4.0
d448b9b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21273

@xiongjiwei xiongjiwei deleted the patch-partition-range branch November 25, 2020 03:54
ti-srebot added a commit that referenced this pull request Nov 25, 2020
@ti-srebot
ddl: compare expression in check partition definition according to co…
af8e479 
…lumn type (#21226) (#21273)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
7 participants
@xiongjiwei @bb7133 @tiancaiamao @ti-srebot @zhouqiang-cl @crazycs520 @wjhuang2016