Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: close transaction for all auto-committed SQLs #21378

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 30, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #21377

Problem Summary:
#19106 introduced it.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Move finishStmt back to what it used to be.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • Close transaction for all auto-committed SQLs.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp requested a review from a team as a code owner November 30, 2020 08:21
@jackysp jackysp requested review from qw4990 and removed request for a team November 30, 2020 08:21
@github-actions github-actions bot added the sig/execution SIG execution label Nov 30, 2020
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp
Copy link
Member Author

jackysp commented Nov 30, 2020

/run-all-tests

@jackysp jackysp changed the title *: close transaction for all SQLs *: close transaction for all auto-committed SQLs Nov 30, 2020
@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
@cfzjywxk cfzjywxk requested a review from lysu November 30, 2020 11:38
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 30, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

/build

@cfzjywxk cfzjywxk added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Nov 30, 2020
@cfzjywxk cfzjywxk added this to the v4.0.9 milestone Nov 30, 2020
@cfzjywxk
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all autocommitted statements closed the transaction
4 participants