Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: close transaction for all auto-committed SQLs (#21378) #21395

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21378 to release-4.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #21377

Problem Summary:
#19106 introduced it.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Move finishStmt back to what it used to be.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • Close transaction for all auto-committed SQLs.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@jackysp you're already a collaborator in bot's repo.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
@jackysp
Copy link
Member

jackysp commented Nov 30, 2020

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2020
@jackysp jackysp merged commit 4f049e5 into pingcap:release-4.0 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants