Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: avoid using index_merge when there are multiple table filters (#22122) #22124

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #22122 to release-4.0


What problem does this PR solve?

Issue Number: close #22105

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
Avoid using index merge when there are multiple table filters.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

  • Avoid using index merge when there are multiple table filters.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@XuHuaiyu you're already a collaborator in bot's repo.

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 31, 2020
@qw4990
Copy link
Contributor

qw4990 commented Dec 31, 2020

/run-all-tests

@jebter jebter modified the milestones: 4.0.0, v4.0.10 Jan 7, 2021
@eurekaka
Copy link
Contributor

eurekaka commented Jan 8, 2021

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @eurekaka, this branch's release version is in progress, please contact zhouqiang-cl,shuke987,jebter,you06 for more details.

@eurekaka
Copy link
Contributor

eurekaka commented Jan 8, 2021

/run-all-tests

@eurekaka
Copy link
Contributor

eurekaka commented Jan 8, 2021

/run-all-tests

1 similar comment
@eurekaka
Copy link
Contributor

eurekaka commented Jan 8, 2021

/run-all-tests

@eurekaka eurekaka merged commit d538ac1 into pingcap:release-4.0 Jan 8, 2021
@eurekaka eurekaka deleted the release-4.0-f1805f3deebd branch January 8, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants