-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix a bug that point get plan returns wrong column name #23365
Conversation
/run-all-tests |
/cc @winoros |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases.
it is hard to use our test framework to test the result column name, I have tried to enhance it, but it will export a lot of variables and changes a lot. So I add a |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ee42cd4
|
/run-unit-test |
@xiongjiwei maybe need cherry-pick to 4.0-5.0 some user need it in oncall |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #23969 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #23970 |
What problem does this PR solve?
Issue Number: close #23291
as #23291 (comment) says,
the results of TiDB are problematic
also, we explicitly select the column name and expect to get the result with the same column name.
Check List
Tests
Release note