Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix a bug that point get plan returns wrong column name #23365

Merged
merged 24 commits into from
Apr 12, 2021

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Mar 17, 2021

What problem does this PR solve?

Issue Number: close #23291

as #23291 (comment) says, the results of TiDB are problematic
also, we explicitly select the column name and expect to get the result with the same column name.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
create table t1(`COL1` varchar(255), PRIMARY KEY (`COL1`));
insert into t1 values("a");
SELECT col1 FROM t1 where col1="a";
+------+
| col1 |    -- it should be lower case
+------+
| a    |
+------+
1 row in set

Release note

  • fix a bug that point get plan returns wrong column name

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2021
@xiongjiwei xiongjiwei marked this pull request as ready for review March 17, 2021 07:02
@xiongjiwei xiongjiwei requested a review from a team as a code owner March 17, 2021 07:02
@xiongjiwei xiongjiwei requested review from eurekaka and removed request for a team March 17, 2021 07:02
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2021
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

/cc @winoros

@ti-chi-bot ti-chi-bot requested a review from winoros March 18, 2021 03:14
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases.

@xiongjiwei
Copy link
Contributor Author

Please add test cases.

it is hard to use our test framework to test the result column name, I have tried to enhance it, but it will export a lot of variables and changes a lot. So I add a Manual test

@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2021
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • eurekaka

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2021
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee42cd4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit fe1cae5 into pingcap:master Apr 12, 2021
@lysu
Copy link
Contributor

lysu commented Apr 12, 2021

@xiongjiwei maybe need cherry-pick to 4.0-5.0 some user need it in oncall

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23969

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The column name is inconsistent with mysql when character set utf8
6 participants