Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix a bug that point get plan returns wrong column name (#23365) #23970

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 12, 2021

cherry-pick #23365 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23970

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23970:release-4.0-fe1cae5f1664

What problem does this PR solve?

Issue Number: close #23291

as #23291 (comment) says, the results of TiDB are problematic
also, we explicitly select the column name and expect to get the result with the same column name.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
create table t1(`COL1` varchar(255), PRIMARY KEY (`COL1`));
insert into t1 values("a");
SELECT col1 FROM t1 where col1="a";
+------+
| col1 |    -- it should be lower case
+------+
| a    |
+------+
1 row in set

Release note

  • fix a bug that point get plan returns wrong column name

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/4.0-cherry-pick labels Apr 12, 2021
@ti-srebot ti-srebot added this to the v4.0.11 milestone Apr 12, 2021
@ti-srebot
Copy link
Contributor Author

@xiongjiwei you're already a collaborator in bot's repo.

@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • eurekaka

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a226f41

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@lysu lysu modified the milestones: v4.0.11, v4.0.13 Apr 15, 2021
@lysu lysu added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 15, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 30, 2021
@ti-chi-bot ti-chi-bot merged commit 3073835 into pingcap:release-4.0 Apr 30, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. priority/release-blocker This issue blocks a release. Please solve it ASAP. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants