Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix subquery update with generated column #23955

Merged
merged 22 commits into from
Apr 15, 2021
Merged

planner: fix subquery update with generated column #23955

merged 22 commits into from
Apr 15, 2021

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Apr 12, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #23947

Problem Summary:

generate column will generate assign to non-updatable subquery part

What is changed and how it works?

Proposal: xxx

What's Changed, How it Works:

don't generate assign to not updatable subquery

Related changes

  • Need to cherry-pick to the release branch 5.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • Fix panic when subquery update stmt the table with generated columns

This change is Reviewable

@lysu lysu requested review from a team as code owners April 12, 2021 06:51
@lysu lysu requested review from qw4990 and hanfei1991 and removed request for a team April 12, 2021 06:51
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2021
@lysu lysu added type/bugfix This PR fixes a bug. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Apr 12, 2021
@lysu lysu requested review from wjhuang2016, cfzjywxk and jackysp and removed request for qw4990 and hanfei1991 April 12, 2021 07:00
@jackysp
Copy link
Member

jackysp commented Apr 12, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2021
@cfzjywxk
Copy link
Contributor

LGTM

@ichn-hu ichn-hu mentioned this pull request Apr 12, 2021
Closed
@cfzjywxk
Copy link
Contributor

This issue does not exist on release-4.0?

@lysu
Copy link
Contributor Author

lysu commented Apr 12, 2021

This issue does not exist on release-4.0?

yes, it's introduced by #23404 and only affect on 5.0

@lysu
Copy link
Contributor Author

lysu commented Apr 13, 2021

LGTM

maybe we need /lgtm 😄

cfzjywxk
cfzjywxk approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@lysu
Copy link
Contributor Author

lysu commented Apr 14, 2021

/merge

@lysu
Copy link
Contributor Author

lysu commented Apr 15, 2021

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Apr 15, 2021

/merge

@lysu
Copy link
Contributor Author

lysu commented Apr 15, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 4d92261 into pingcap:master Apr 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 15, 2021
@lysu @ti-srebot
cherry pick pingcap#23955 to release-5.0
2c00fb4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24055

@lysu lysu deleted the dev-fix-update-join branch April 15, 2021 10:37
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
planner: fix subquery update with generated column (#23955) (#24055)
aaf6235
time-and-fate pushed a commit to time-and-fate/tidb that referenced this pull request May 14, 2021
@lysu @time-and-fate
planner: fix subquery update with generated column (pingcap#23955)
10a725f
time-and-fate pushed a commit to time-and-fate/tidb that referenced this pull request May 14, 2021
@lysu @time-and-fate
planner: fix subquery update with generated column (pingcap#23955)
e1b5b18
@time-and-fate time-and-fate mentioned this pull request May 14, 2021
Merged
ti-chi-bot pushed a commit that referenced this pull request May 14, 2021
@time-and-fate
planner: fix subquery update with generated column (#23955) (#24658)
4f31cb4
xiongjiwei pushed a commit to xiongjiwei/tidb that referenced this pull request May 18, 2021
@lysu @xiongjiwei
planner: fix subquery update with generated column (pingcap#23955)
236632d 
(cherry picked from commit 4d92261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update join paniced with generated column tables
6 participants
@lysu @jackysp @cfzjywxk @ti-chi-bot @ti-srebot @wjhuang2016